Re: [PATCH v15 14/23] KVM: selftests: Expose function to allocate vCPU stack
From: Lisa Wang
Date: Tue Oct 13 2026 - 15:04:38 EST
On Sat, Oct 10, 2026 at 11:54:42AM +0800, Binbin Wu wrote:
> >>
> >> -struct kvm_vcpu *vm_arch_vcpu_add(struct kvm_vm *vm, u32 vcpu_id)
> >> +gva_t kvm_allocate_vcpu_stack(struct kvm_vm *vm)
> >
> > Besides what Sashiko pointed out[1], this patch was just messed up during the
> > rebase and it even doesn't compile.
>
>
> Yes.
>
> And since the upstream code already has vm_alloc_stack(), which basically does
> the same thing.
>
> I think this patch can be dropped.
>
> >
> > [1] https://lore.kernel.org/all/20261002091331.BA23F1F00893@xxxxxxxxxxxxxxx/
Yes.
vm_alloc_stack() can replace kvm_allocate_vcpu_stack(). I will drop this
patch in the next version.
Thanks!