Re: [PATCH v2 2/2] PCI: tegra194: Propagate REFCLK select GPIO errors
From: Thierry Reding
Date: Tue Oct 13 2026 - 16:17:14 EST
On Mon, Oct 12, 2026 at 04:48:15PM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> devm_gpiod_get_optional() returns NULL when the optional GPIO is not
> present, but may return -EPROBE_DEFER or other errors.
>
> The current code treats GPIO lookup errors as if the GPIO were not
> present.
>
> Check the return value and propagate errors from the REFCLK select GPIO
> lookup.
>
> Reviewed-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
>
> Changes in v2:
> - Follow the subject line capitalization style.
>
> drivers/pci/controller/dwc/pcie-tegra194.c | 15 +++------------
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature