[PATCH net-next v3 2/5] bnge: add bnge_err()/bnge_warn()/bnge_dbg() logging helpers
From: Bhargava Marreddy
Date: Tue Oct 13 2026 - 16:34:22 EST
netdev_err() and netdev_warn() print "(unnamed net_device)
(uninitialized)" instead of the interface name while the netdev has not
been registered yet. Later patches in this series run NQ0 init before
register_netdev() in probe, so messages from the HWRM ring alloc/free
paths and from NQ0's NAPI would be logged that way.
Add bnge_err(), bnge_warn() and bnge_dbg(), which take a struct bnge_dev
and log through the netdev once it has been registered, including while
it is being unregistered and after, where it keeps its name. Before
that, fall back to dev_err()/dev_warn()/dev_dbg() on the PCI device.
Convert the HWRM ring alloc/free error messages, the IRQ affinity hint
warning and the async event debug message, which are reachable from
those paths. No other message is changed.
No functional change.
Signed-off-by: Bhargava Marreddy <bhargava.marreddy@xxxxxxxxxxxx>
Reviewed-by: Dharmender Garg <dharmender.garg@xxxxxxxxxxxx>
Reviewed-by: Kumar Mudide <kumar.mudide@xxxxxxxxxxxx>
Reviewed-by: Ramakrishna Koduri <ramakrishna.koduri@xxxxxxxxxxxx>
---
drivers/net/ethernet/broadcom/bnge/bnge.h | 18 ++++++++++++++++++
.../net/ethernet/broadcom/bnge/bnge_hwrm_lib.c | 8 +++++---
.../net/ethernet/broadcom/bnge/bnge_netdev.c | 5 ++---
drivers/net/ethernet/broadcom/bnge/bnge_txrx.c | 4 ++--
4 files changed, 27 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge.h b/drivers/net/ethernet/broadcom/bnge/bnge.h
index 4479ccd071f5..e76ba4e063bb 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge.h
+++ b/drivers/net/ethernet/broadcom/bnge/bnge.h
@@ -220,6 +220,24 @@ struct bnge_dev {
u32 phy_flags;
};
+/* The netdev has no name until register_netdev(), so log through the PCI
+ * device before that (e.g. during probe).
+ */
+#define bnge_log(level, bd, fmt, ...) \
+ do { \
+ struct bnge_dev *__bd = (bd); \
+ \
+ if (__bd->netdev && \
+ READ_ONCE(__bd->netdev->reg_state) != NETREG_UNINITIALIZED)\
+ netdev_##level(__bd->netdev, fmt, ##__VA_ARGS__);\
+ else \
+ dev_##level(__bd->dev, fmt, ##__VA_ARGS__); \
+ } while (0)
+
+#define bnge_err(bd, fmt, ...) bnge_log(err, bd, fmt, ##__VA_ARGS__)
+#define bnge_warn(bd, fmt, ...) bnge_log(warn, bd, fmt, ##__VA_ARGS__)
+#define bnge_dbg(bd, fmt, ...) bnge_log(dbg, bd, fmt, ##__VA_ARGS__)
+
static inline bool bnge_is_roce_en(struct bnge_dev *bd)
{
return bd->flags & BNGE_EN_ROCE;
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
index 651c5e783516..fb960bff85fa 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
@@ -1302,7 +1302,8 @@ int hwrm_ring_free_send_msg(struct bnge_net *bn,
bnge_hwrm_req_drop(bd, req);
exit:
if (rc) {
- netdev_err(bd->netdev, "hwrm_ring_free type %d failed. rc:%d\n", ring_type, rc);
+ bnge_err(bd, "hwrm_ring_free type %d failed. rc:%d\n",
+ ring_type, rc);
return -EIO;
}
return 0;
@@ -1395,7 +1396,7 @@ int hwrm_ring_alloc_send_msg(struct bnge_net *bn,
req->int_mode = RING_ALLOC_REQ_INT_MODE_MSIX;
break;
default:
- netdev_err(bn->netdev, "hwrm alloc invalid ring type %d\n", ring_type);
+ bnge_err(bd, "hwrm alloc invalid ring type %d\n", ring_type);
return -EINVAL;
}
@@ -1406,7 +1407,8 @@ int hwrm_ring_alloc_send_msg(struct bnge_net *bn,
exit:
if (rc) {
- netdev_err(bd->netdev, "hwrm_ring_alloc type %d failed. rc:%d\n", ring_type, rc);
+ bnge_err(bd, "hwrm_ring_alloc type %d failed. rc:%d\n",
+ ring_type, rc);
return -EIO;
}
ring->fw_ring_id = ring_id;
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
index 8cd0d8bd68c2..f8f81f3f7cd9 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
@@ -2696,9 +2696,8 @@ static int bnge_nq_request_irq(struct bnge_net *bn, struct bnge_napi *bnapi)
cpumask_set_cpu(cpumask_local_spread(bnapi->index, numa_node),
irq->cpu_mask);
if (irq_set_affinity_hint(irq->vector, irq->cpu_mask))
- netdev_warn(bn->netdev,
- "Set affinity failed, IRQ = %d\n",
- irq->vector);
+ bnge_warn(bd, "Set affinity failed, IRQ = %d\n",
+ irq->vector);
}
return 0;
}
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c
index 472b02cc43b3..2f382514c6ea 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c
@@ -1135,8 +1135,8 @@ static void bnge_async_event_process(struct bnge_net *bn,
u32 data1 = le32_to_cpu(cmpl->event_data1);
u32 data2 = le32_to_cpu(cmpl->event_data2);
- netdev_dbg(bn->netdev, "hwrm event 0x%x {0x%x, 0x%x}\n",
- event_id, data1, data2);
+ bnge_dbg(bn->bd, "hwrm event 0x%x {0x%x, 0x%x}\n",
+ event_id, data1, data2);
switch (event_id) {
case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE:
--
2.47.3