Re: [PATCH net-next v12 03/12] dpll: add basic SiTime SiT9531x support

[Ali Rouhi]

On Tue, 13 Oct 2026, Ivan Vecera wrote:

> > +const struct regmap_config sit9531x_regmap_config = {
> > +       .reg_bits       = 8,
> > +       .val_bits       = 8,
> > +       .max_register   = SIT9531X_RANGE_OFFSET +
> > +                         (SIT9531X_NUM_PAGES * SIT9531X_PAGE_SIZE) - 1,
> > +       .ranges         = &sit9531x_regmap_range,
> > +       .num_ranges     = 1,
> > +       .volatile_reg   = sit9531x_volatile_reg,
> > +       .cache_type     = REGCACHE_MAPLE,
> > +};
>
> This is only referenced from core.c. Could it be static, with the extern
> declarations dropped from core.h?
>
> The same for sit9531x_dev_probe().

Both are static in v13 and the two declarations are gone from core.h,
with your Suggested-by on the patch.

The same applies in patch 5 to sit9531x_dev_start(),
sit9531x_dev_stop() and sit9531x_clear_notifications(), which only
core.c calls. Their declarations are gone from core.h too.

Thanks,
Ali