RE: [PATCH v5 net-next 4/9] net: dsa: netc: tie setup resources and reset to DSA setup/teardown

[Wei Fang (OSS)]

Best Regards,
Wei Fang

> -----Original Message-----
> From: netdev-bot+sashiko@xxxxxxxxxx <netdev-bot+sashiko@xxxxxxxxxx>
> Sent: 2026年10月13日 18:58
> To: Wei Fang (OSS) <wei.fang@xxxxxxxxxxx>
> Cc: Clark Wang <xiaoning.wang@xxxxxxx>; andrew@xxxxxxx;
> olteanv@xxxxxxxxx; andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> horms@xxxxxxxxxx; richardcochran@xxxxxxxxx; linusw@xxxxxxxxxx; Wei Fang
> <wei.fang@xxxxxxx>; imx@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 net-next 4/9] net: dsa: netc: tie setup resources and
> reset to DSA setup/teardown
> 
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 · Medium: 2 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] netc_setup() now calls pci_reset_function(A->pdev) whenever
>   A->in_probe is false.
> - [Medium] priv->in_probe is a plain bool.
> - [Medium] Moving the initial reset from before pcim_enable_device() into
>   netc_setup() means pci_set_master() (netc_switch_pci_init(), line…

I agree with the issues reported by sashiko and will fix them in the next version.

--
pw-bot: cr