Re: [PATCH v8 9/9] serial: max310x: don't transmit while an RS485 reconfigure is pending
From: Tapio Reijonen
Date: Wed Oct 14 2026 - 03:24:13 EST
On 10/8/26 13:03, sashiko-bot@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- tx_work continuing through a pending reconfigure is an in-flight
transfer, which the reconfigure helper adopts with RTS held - the
gate's documented scope is transmissions that have not started;
- max310x_handle_tx() has exactly one consumer, tx_work, so the kfifo
single-consumer contract holds;
- rs_work not being cancelled in shutdown() predates this series
(2016); it belongs to the same teardown-ordering follow-up as the
patch-7 note.
Tapio