Re: [PATCH v1 2/3] dt-bindings: leds: skyworks,aat1290: Document FLINH pin

[Svyatoslav Ryhel]

ср, 14 жовт. 2026 р. о 12:17 Lee Jones <lee@xxxxxxxxxx> пише:
>
> On Tue, 13 Oct 2026, Jacek Anaszewski wrote:
>
> > On 10/12/26 9:25 AM, Svyatoslav Ryhel wrote:
> > > нд, 11 жовт. 2026 р. о 20:35 Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> пише:
> > > >
> > > > On 10/11/26 3:55 PM, Svyatoslav Ryhel wrote:
> > > > > нд, 11 жовт. 2026 р. о 16:28 Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> пише:
> > > > > >
> > > > > > Hi Svyatoslav,
> > > > > >
> > > > > > On 10/7/26 10:54 AM, Svyatoslav Ryhel wrote:
> > > > > > > Both the AAT1270 and AAT1290 feature a FLINH pin used for mandatory Flash
> > > > > > > inhibition.
> > > > > > >
> > > > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > > > > > > ---
> > > > > > >     Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml | 4 ++++
> > > > > > >     1 file changed, 4 insertions(+)
> > > > > > >
> > > > > > > diff --git a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
> > > > > > > index a65d92522c9cf..596b5e284f44a 100644
> > > > > > > --- a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
> > > > > > > +++ b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
> > > > > > > @@ -31,6 +31,10 @@ properties:
> > > > > > >         maxItems: 1
> > > > > > >         description: FL_EN pin
> > > > > > >
> > > > > > > +  flinh-gpios:
> > > > > > > +    maxItems: 1
> > > > > > > +    description: FLINH pin
> > > > > > > +
> > > > > >
> > > > > > You don't seem to make use of it in your patch.
> > > > > >
> > > > >
> > > > > I don't have to use it in my patch. This change completes and improves
> > > > > hardware description of the AAT1290/1270.
> > > >
> > > > Still, If we don't have the use case I'd avoid adding it to not confuse
> > > > people looking for its use in the driver.
> > > >
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/writing-bindings.rst?h=next-20261009#n17
> > >
> > > - DO attempt to make bindings complete even if a driver doesn't
> > > support some features. For example, if a device has an interrupt, then
> > > include the 'interrupts' property even if the driver is only polled
> > > mode.
> > >
> > > - DON'T refer to Linux or "device driver" in bindings. Bindings should
> > > be based on what the hardware has, not what an OS and driver currently
> > > support.
> >
> > I'll leave it to the maintainer.
>
> DT should be OS agnostic and driver orthogonal.  So long as it
> accurately and indisputably describes the H/W, then I think it's fair
> game.
>
> Is `flinh` a datasheet term or did we make this up?
>

You can check yourself if you don't believe me. Both AAT1270 and
AAT1290 can be found freely.

FLINH pin #10

Flash inhibit pin. FLINH is an active HIGH control input with an
internal 200kΩ resistor to AGND. A low-to-high transition on the FLINH
pin reduces FL sink current to the maximum (default) movie-mode
current level for the duration of FLINH. Strobing the FLINH pin low to
high does not reset the flash timer.

> --
> Lee Jones