Re: [PATCH v2 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard

From: wyibo6109

Date: Wed Oct 14 2026 - 10:22:49 EST


From: Yibo Wang <wyibo6109@xxxxxxxxx>

Hi Krzysztof,

On 12/10/2026 01:24, Krzysztof Kozlowski wrote:
> How is that possible? Same OnePlus Pad 3 Pro has different matrices?

No, and sorry for the wording - within one tablet project the keyboard
is fixed. What I meant is that the matrices differ *between* the
tablet projects that ship this MCU, not within one: the vendor trees
carry per-project geometry (caihong, the sm8650 era project: 2764x1630;
erhai, the sm8750 era project: 2764x1630; iceland, the sm8850 era
project the tested OnePlus Pad 4 belongs to: 2560x1440), while the MCU
protocol has no command to query them.

Which also means your question from v1 is answered the other way
around: the geometry *is* deducible from the compatible once the
compatible names the project. v3 therefore drops the DT geometry
entirely:

- the compatible names the tablet project
(oneplus,caihong-/erhai-/iceland-pogo-keyboard, the codenames from
the vendor trees) and the driver carries a per-project description
in its match data: feature flags for the 0x3A sub-commands that grew
over the generations, the touchpad geometry and the per-brand
product names;

- the common touchscreen properties (touchscreen-size-x/y,
touchscreen-x-mm/y-mm) are kept only as an optional override, in
case a variant ever needs one, and are no longer used by the
example.

v3 will follow as a reply to the cover letter.

Best regards,
Yibo