Re: [PATCH] HID: wacom: fix wacom_intuos_irq NULL pen_input deref

[Jason Gerecke]

On Wed, Oct 7, 2026 at 8:35 PM Matheus Alves de Almeida
<matheus.aalmeida@xxxxxxxxxxxx> wrote:
>
> Em 2026-09-23 23:09, Matheus Alves de Almeida escreveu:
> > Currently, wacom_intuos_irq() passes the parent of wacom_wac's
> > pen_input to the dev_dbg() in the unknown report path. However,
> > pen_input can be NULL on interfaces without a pen, causing a
> > NULL pointer dereference.
> >
> > Get the HID device from the enclosing struct wacom and use hid_dbg()
> > instead.
> >
> > Fixes: eb71d1bb270e ("Input: wacom - use dev_xxx() instead of naked
> > printk()s
> > and dbg()s")
> > Reported-by: syzbot+b5a7cd83622c747977de@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Closes: https://syzkaller.appspot.com/bug?extid=b5a7cd83622c747977de
> > Signed-off-by: Matheus Alves de Almeida <matheus.aalmeida@xxxxxxxxxxxx>
>
> Hi,
>
> Gentle ping on this. Has anyone been able to take a look at it yet?
>
> Matheus
>

Apologies for the delay... I've reviewed the patch and it looks good.
It does make me wonder about similar patterns elsewhere in the code
though (calling `dev_dbg(input->dev.parent, ...)` isn't unique to this
function). I'm happy to take this as a standalone fix for an observed
crash, but an audit of other log statements is still probably
reasonable.

Reviewed-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>

Jason (she/they)
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one  /
(That is to say, eight) to the two,     /
But you can’t take seven from three,    /
So you look at the sixty-fours....