Re: [PATCH v3 0/2] x86/sev: Fix RMPOPT enablement on non-RMPOPT configs

[Borislav Petkov]

On Wed, Oct 14, 2026 at 11:06:32PM +0000, Ashish Kalra wrote:
> From: Ashish Kalra <ashish.kalra@xxxxxxx>
> 
> Two fixes for the RMPOPT series, both for configurations where the
> RMPOPT CPUID bit is advertised but RMPOPT is not actually usable:

Those are clearly not settled yet.

But you don't have to rush them, take your time with, test them more and
analyze better what you're fixing instead of piling more stuff ontop.

And avoid all that unnecessary commenting you're doing. The stuff you're
saying belongs in the commit message - not spread around the code.

If the code needs more explanation, then perhaps it needs to be simplified
and split properly.

I'm not at all happy about how intertwined and inter-dependent and thus
fragile our SNP init gunk is.

So think about that too, perhaps it can be simplified even more.

I'll take the final versions later, during the 7.4 stabilization phase.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette