Re: [PATCH v4] perf bench: Add atomic operations benchmark
From: Namhyung Kim
Date: Thu Oct 15 2026 - 00:07:26 EST
On Thu, Oct 15, 2026 at 10:38:17AM +0800, Changbin Du wrote:
> On Wed, Oct 14, 2026 at 02:28:02PM -0700, Namhyung Kim wrote:
> > On Tue, Oct 13, 2026 at 04:56:48PM +0800, Changbin Du wrote:
> [..]
> > > +
> > > +static const struct option options[] = {
> > > + OPT_UINTEGER('t', "threads", &threads,
> > > + "Number of contending threads (default: 2, or 1 on single CPU)"),
> > > + OPT_UINTEGER('r', "runtime", &runtime,
> >
> > Can you please pick a different short option than 'r'? perf bench
> > itself has -r/--repeat option so it would be confusing. It doesn't
> > clash for now, but I think it's better to use perf bench options from
> > 'perf bench atomic ...' later.
> >
>
> Agreed -- I'll drop the short options; --threads and --runtime
> stay long-only so no bench option (e.g. -r/--repeat) is shadowed
> at perf bench atomic .... Will send an updated patch.
Well.. but short options are easier to use. I think you can use 'R' and
'T' instead.
Thanks,
Namhyung