Re: [PATCH v2 1/2] dt-bindings: usb: gadget: udc: add Axiado AX3000 and AX3005 UDC

[Petar Stepanovic]

On 8/21/2026 9:41 AM, Krzysztof Kozlowski wrote:
> On Mon, Aug 17, 2026 at 10:57:13PM -0700, Naveen Kumar Rajgiri Bassappa wrote:
>> +title: Axiado AX3000/AX3005 USB Device Controller
>> +
>> +maintainers:
>> +  - Naveen Kumar Rajgiri Bassappa <rbnaveenkumar@xxxxxxxxxx>
>> +  - Krutik Shah <krutikshah@xxxxxxxxxx>
>> +  - Prasad Bolisetty <pbolisetty@xxxxxxxxxx>
>> +
>> +description:
>> +  Axiado USB Device Controller (UDC) is used on the AX3000 and AX3005
>> +  SoCs. This controller is based on a Corigine USB IP core and provides
>> +  SuperSpeed (5 Gb/s) or High-Speed (480 Mb/s) operation, selected by the
>> +  maximum-speed property. It supports control, bulk, interrupt, and
>> +  isochronous transfer types across multiple configurable endpoints. The
>> +  node describes the memory-mapped register region, interrupt line, and
>> +  other required properties for the UDC hardware.
> Did you implement my comment?
Sorry, we overlooked this comment in the current revision. We'll address it in the next version.
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: axiado,ax3000-udc
>> +      - items:
>> +          - const: axiado,ax3005-udc
>> +          - const: axiado,ax3000-udc
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  resets:
>> +    maxItems: 1
>> +
>> +  phys:
>> +    maxItems: 1
>> +
>> +  maximum-speed:
>> +    enum: [super-speed, high-speed]
> You miss referencing proper schema to get such property or you should
> not come with own generic properties. IOW, look at other bindings how
> they define a proper UDC device schema.
>
>
> I also do not see a need for this, compatible defines max speed.

Agreed. We'll remove this property in the next revision.

>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    soc {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +
>> +        usb@81200000 {
>> +            compatible = "axiado,ax3000-udc";
>> +            reg = <0x0 0x81200000 0x0 0x00100000>;
>> +            interrupt-parent = <&gic500>;
>> +            interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> resets, phys. Make example complete.

We'll update the example to include the missing resets and phys properties in the next revision.

>> +            maximum-speed = "high-speed";
>> +        };
>> +    };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a674e36529f7..36af69fb965b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4468,6 +4468,14 @@ F:	Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml
>>  F:	drivers/spi/spi-axiado.c
>>  F:	drivers/spi/spi-axiado.h
>>  
>> +AXIADO USB UDC DRIVER
>> +M:	Naveen Kumar Rajgiri Bassappa <rbnaveenkumar@xxxxxxxxxx>
>> +M:	Krutik Shah <krutikshah@xxxxxxxxxx>
>> +M:	Prasad Bolisetty <pbolisetty@xxxxxxxxxx>
>> +L:	linux-usb@xxxxxxxxxxxxxxx
>> +S:	Supported
>> +F:	Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml
>> +
>>  AYANEO PLATFORM EC DRIVER
>>  M:	Antheas Kapenekakis <lkml@xxxxxxxxxxx>
>>  L:	platform-driver-x86@xxxxxxxxxxxxxxx
>>
>> -- 
>> 2.34.1
>>
Best regards,
Petar Stepanovic