Re: [REGRESSION] qcom/qcom-msm8960-samsung-expressatt: SSH over USB no longer works

[Xu Yang]

Hi Rudraksha and Thorsten,

Sorry for late reply. 
Thank you for reporting the issue! I just have time to debug the issue.

On Tue, Oct 13, 2026 at 12:58:13PM +0200, Thorsten Leemhuis wrote:
> On 10/1/26 04:39, Rudraksha Gupta wrote:
> > On 9/29/26 03:43, Rudraksha Gupta wrote:
> >
> >> I can no longer SSH in via USB. Reverting
> >> dd0c03d685225cb8fc60c477417d1b9c3b05ba9d fixes the issue.
> 
> FWIW, that is dd0c03d685225c ("usb: chipidea: udc: support dynamic
> gadget add/remove") [v7.2-rc1] from Xu Yang, committed by Greg.
> 
> >> Please see below on logs that I captured over UART (v7.3.0-rc5) and
> >> USB (v7.3.0-rc5 + revert).
> >>
> >> Distro is Nura (formerly postmarketOS). Using head of pmbootstrap/
> >> pmaports. Instructions for this device:
> >> https://wiki.nura.eco/wiki/Samsung_Galaxy_Express_SGH-I437_(samsung-
> >> expressatt)
> > 
> > I have identified the culprit:
> > 
> >> CONFIG_USB_OTG_FSM=y
> > 
> > If (v7.3.0-rc5 + revert), then regardless of CONFIG_USB_OTG_FSM, SSH
> > over USB works.
> > 
> > If (v7.3.0-rc5), then CONFIG_USB_OTG_FSM cannot be set to y. It must be
> > not set.
> Well, that is good to know, but shouldn't happen.
> 
> @Xu Yang: do you might have any idea what might be wrong here? Is this
> something we should revert to "regroup and rethink" the approach and
> reapply it later in improved form?

So my previous patch break otg fsm mode switch function.
I have reproduced the issue on my hand, and send a fix patch (cc you).

Please give a tag if it works for you.

Thanks，
Xu Yang