Re: [PATCH 2/4] arm64: dts: qcom: nord: Add iris video node

[Shawn Guo]

On Thu, Oct 15, 2026 at 02:41:26PM +0530, Gourav Kumar wrote:
> 
> 
> On 9/20/2026 6:46 PM, Shawn Guo wrote:
> > On Sat, Sep 19, 2026 at 10:14:56AM +0530, Vishnu Reddy wrote:
> >> Add iris video codec to nord SoC, which comes with significantly different
> >> powering up sequence than previous platforms, thus different clocks and
> >> resets.
> >>
> >> Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> >> ---
> >>  arch/arm64/boot/dts/qcom/nord-embedded.dtsi | 114 ++++++++++++++++++++++++++++
> >>  1 file changed, 114 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> >> index 74f4e6be8652..03f827f3e5fc 100644
> >> --- a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> >> @@ -1428,6 +1428,120 @@ camcc: clock-controller@9ce0000 {
> >>  		#power-domain-cells = <1>;
> >>  	};
> >>  
> >> +	iris: video-codec@aa00000 {
> >> +		compatible = "qcom,nord-iris", "qcom,glymur-iris";
> >> +		reg = <0x0 0x0aa00000 0x0 0xf0000>;
> > 
> > nord-embedded.dtsi is a place to accommodate Nord Embedded variant
> > specific resource descriptions, like clock, regulator, pinctrl,
> > interconnect, power domain, PHY, etc. The rest of descriptions should
> > go to nord.dtsi, like reg, interrupts, iommu, dma, etc.
> > 
> 
> Iris depends on providers such as videocc, nwgcc, hscnoc, and mc_virt,
> which are defined only in nord-embedded.dtsi.
> Moving the Iris node into nord.dtsi would leave unresolved references in
> DTS variants that don’t include the embedded file, causing DTB build
> failures.
> We should keep the iris node in nord-embedded.dtsi.

Could you read my comment one more time? I was asking to split the Iris
node, move descriptions like reg, interrupts, iommu, dma, etc to
nord.dtsi, and keep clocks, resets, interconnects, power domains, etc
in nord-embedded.dtsi. Take a look at the existing device nodes as
examples, that's already what we are doing.

Shawn