Re: [PATCH v4 2/2] ASoC: airoha: Add support for AN7581 PCM driver

[Philipp Zabel]

On Mo, 2026-10-12 at 13:54 +0200, Christian Marangi wrote:
> The Airoha AN7581 SoC provides a PCM interface for VoIP applications,
> supporting playback and capture at sample rates of 8 kHz and 16 kHz.
> The driver configures the PCM bit clock to 2.048 MHz and supports
> 8-bit and 16-bit samples, with up to 32 channels.
> 
> Add an ASoC platform driver for the AN7581 PCM controller configured for
> ZSI attached voice chip.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
>  MAINTAINERS                   |   7 +
>  sound/soc/Kconfig             |   1 +
>  sound/soc/Makefile            |   1 +
>  sound/soc/airoha/Kconfig      |  10 +
>  sound/soc/airoha/Makefile     |   3 +
>  sound/soc/airoha/an7581-pcm.c | 904 ++++++++++++++++++++++++++++++++++
>  6 files changed, 926 insertions(+)
>  create mode 100644 sound/soc/airoha/Kconfig
>  create mode 100644 sound/soc/airoha/Makefile
>  create mode 100644 sound/soc/airoha/an7581-pcm.c
> 
[...]
> diff --git a/sound/soc/airoha/an7581-pcm.c b/sound/soc/airoha/an7581-pcm.c
> new file mode 100644
> index 000000000000..568c11dc7e6b
> --- /dev/null
> +++ b/sound/soc/airoha/an7581-pcm.c
> @@ -0,0 +1,904 @@
[...]
> +
> +struct an7581_pcm_priv {
> +	struct regmap *map;
> +	struct reset_control *reset;

This doesn't seem to be used anywhere other than _probe?
Could be a local variable there.

regards
Philipp