Re: [PATCH v2] arm64: dts: qcom: sc8280xp: add missing QUP pinctrl states

[Konrad Dybcio]

On 8/31/26 11:55 AM, Xilin Wu wrote:
> Add the missing tlmm pinctrl states for the SC8280XP QUP engines so common
> I2C, SPI and UART pinmux definitions are available from the SoC dtsi.
> Populate all 24 engines using the SC8280XP lane-to-GPIO mapping, including
> the non-linear QUP instances, and keep the mux function names aligned with
> the driver-supported qup0..qup23 names.

[...]

> +			qup_uart0_default: qup-uart0-default-state {
> +				cts-pins {
> +					pins = "gpio135";
> +					function = "qup0";
> +					bias-bus-hold;
> +				};
> +				rts-pins {

Please keep a \n between each subnode, there's a new tool in town
that will be very grumpy if you don't:

https://lore.kernel.org/linux-arm-msm/cover.1790892852.git.waqar.hameed@xxxxxxxx/

https://lore.kernel.org/linux-arm-msm/e869c2bb5005830c9ac1d4bf998696ffc4eed335.1790892852.git.waqar.hameed@xxxxxxxx/

with that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad