[tip: irq/drivers] irqchip/al-fic: Use %pOF and raise init log level

From: tip-bot2 for Eliav Farber

Date: Thu Oct 15 2026 - 08:39:57 EST


The following commit has been merged into the irq/drivers branch of tip:

Commit-ID: da0b1e5f7a124c5c506baef32ed7a90aa03cf516
Gitweb: https://git.kernel.org/tip/da0b1e5f7a124c5c506baef32ed7a90aa03cf516
Author: Eliav Farber <farbere@xxxxxxxxxx>
AuthorDate: Sun, 11 Oct 2026 05:04:42
Committer: Thomas Gleixner <tglx@xxxxxxxxxx>
CommitterDate: Thu, 15 Oct 2026 14:25:06 +02:00

irqchip/al-fic: Use %pOF and raise init log level

Use %pOF in the driver's log messages, so that both the success and the
error paths identify the specific FIC instance by its full devicetree
path rather than by its bare node name, e.g.:

/soc/interrupt-controller@fd803000 initialized successfully in Legacy mode (parent-irq=3)

A single controller is described by several FIC nodes that share the same
bare node name (e.g. "interrupt-controller"), so the bare name cannot tell
one instance from another. The full path includes the unit address and
keeps the instances distinguishable.

While converting the parent-missing message, fix a grammar typo in it
("device require a parent" -> "device requires a parent").

Raise the successful-initialization message from pr_debug to pr_info, as
this single boot-time printout is useful when dynamic debug is not enabled
at this stage of boot.

Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxx>
Reviewed-by: Radu Rendec <radu@xxxxxxxxxx>
Link: https://patch.msgid.link/20261011050449.41903-4-farbere@xxxxxxxxxx
---
drivers/irqchip/irq-al-fic.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-al-fic.c b/drivers/irqchip/irq-al-fic.c
index a513d0d..ac979c3 100644
--- a/drivers/irqchip/irq-al-fic.c
+++ b/drivers/irqchip/irq-al-fic.c
@@ -205,8 +205,8 @@ static struct al_fic *al_fic_wire_init(struct device_node *node, void __iomem *b
goto err_free;
}

- pr_debug("%s initialized successfully in Legacy mode (parent-irq=%u)\n",
- fic->name, parent_irq);
+ pr_info("%pOF initialized successfully in Legacy mode (parent-irq=%u)\n",
+ node, parent_irq);

return fic;

@@ -223,19 +223,19 @@ static int __init al_fic_init_dt(struct device_node *node, struct device_node *p
int ret;

if (!parent) {
- pr_err("%s: unsupported - device require a parent\n", node->name);
+ pr_err("%pOF: unsupported - device requires a parent\n", node);
return -EINVAL;
}

base = of_iomap(node, 0);
if (!base) {
- pr_err("%s: fail to map memory\n", node->name);
+ pr_err("%pOF: fail to map memory\n", node);
return -ENOMEM;
}

parent_irq = irq_of_parse_and_map(node, 0);
if (!parent_irq) {
- pr_err("%s: fail to map irq\n", node->name);
+ pr_err("%pOF: fail to map irq\n", node);
ret = -EINVAL;
goto err_unmap;
}
@@ -243,7 +243,7 @@ static int __init al_fic_init_dt(struct device_node *node, struct device_node *p
fic = al_fic_wire_init(node, base, node->name, parent_irq);

if (IS_ERR(fic)) {
- pr_err("%s: fail to initialize irqchip (%pe)\n", node->name, fic);
+ pr_err("%pOF: fail to initialize irqchip (%pe)\n", node, fic);
ret = PTR_ERR(fic);
goto err_irq_dispose;
}