[tip: irq/drivers] irqchip/al-fic: Use %pe to print init error
From: tip-bot2 for Eliav Farber
Date: Thu Oct 15 2026 - 08:40:19 EST
The following commit has been merged into the irq/drivers branch of tip:
Commit-ID: e86459748d3119e18faee281408f5452865bfea4
Gitweb: https://git.kernel.org/tip/e86459748d3119e18faee281408f5452865bfea4
Author: Eliav Farber <farbere@xxxxxxxxxx>
AuthorDate: Sun, 11 Oct 2026 05:04:41
Committer: Thomas Gleixner <tglx@xxxxxxxxxx>
CommitterDate: Thu, 15 Oct 2026 14:25:06 +02:00
irqchip/al-fic: Use %pe to print init error
al_fic_init_dt() logs PTR_ERR(fic) with %lu when al_fic_wire_init()
fails. PTR_ERR() returns a signed long, so printing it with an
unsigned format specifier turns a negative error code into a large
positive value, making it harder to read.
Pass fic to %pe directly instead of unwrapping it with PTR_ERR()
first. %pe accepts the ERR_PTR-encoded pointer itself and prints a
symbolic error name (e.g. -EINVAL) when one is known, falling back
to the plain decimal value otherwise.
Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxx>
Reviewed-by: Radu Rendec <radu@xxxxxxxxxx>
Link: https://patch.msgid.link/20261011050449.41903-3-farbere@xxxxxxxxxx
---
drivers/irqchip/irq-al-fic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-al-fic.c b/drivers/irqchip/irq-al-fic.c
index adcdc05..a513d0d 100644
--- a/drivers/irqchip/irq-al-fic.c
+++ b/drivers/irqchip/irq-al-fic.c
@@ -243,7 +243,7 @@ static int __init al_fic_init_dt(struct device_node *node, struct device_node *p
fic = al_fic_wire_init(node, base, node->name, parent_irq);
if (IS_ERR(fic)) {
- pr_err("%s: fail to initialize irqchip (%lu)\n", node->name, PTR_ERR(fic));
+ pr_err("%s: fail to initialize irqchip (%pe)\n", node->name, fic);
ret = PTR_ERR(fic);
goto err_irq_dispose;
}