Re: [PATCH v2] iio: ccs811: Deassert WAKE GPIO on error paths
From: Joshua Crofts
Date: Thu Oct 15 2026 - 09:06:53 EST
On Thu, 15 Oct 2026 18:00:23 +0530
Nikhil Gautam <nikhilgtr@xxxxxxxxx> wrote:
> Ensure the WAKE GPIO is deasserted when status polling fails or
> the data-ready timeout expires. Early returns could leave WAKE asserted,
> preventing the sensor from returning to its low-power state and
> potentially disrupting subsequent I2C transactions.
>
> Route error paths through a common cleanup label to ensure WAKE is
> deasserted before returning.
>
> Fixes: c6644f7201f3 ("iio: chemical: Add support for external Reset and Wakeup in CCS811")
> Signed-off-by: Nikhil Gautam <nikhilgtr@xxxxxxxxx>
Ideally your signed-off-by should be last in the tag block.
No need to resend though.
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> ---
You were too fast! Wait at least 24 hours before submitting a new
patch, you might get more reviews.
--
Kind regards,
Joshua Crofts