Re: [PATCH] selftests/ftrace: Add nice dependency

[Google]

On Thu, 15 Oct 2026 11:23:39 +0900, Jaewon Jung <jaewon8868@xxxxxxxxx> wrote:
> The tests use nice but do not list it as a requirement.
> Add nice to the requirements so the tests are unresolved, not failed,
> when it is not available.
>
> Signed-off-by: Jaewon Jung <jaewon8868@xxxxxxxxx>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Shuah, will you pick this via your selftest branch?

Thank you,

> ---
>  .../test.d/trigger/inter-event/trigger-onchange-action-hist.tc  | 2 +-
>  .../test.d/trigger/inter-event/trigger-snapshot-action-hist.tc  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> index 55ab0270e5f7..04e6db2a734d 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: event trigger - test inter-event histogram trigger onchange action
> -# requires: set_event "onchange(var)":README ping:program
> +# requires: set_event "onchange(var)":README ping:program nice:program
>  # flags: instance
>  
>  fail() { #msg
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
> index 9eb37c2fa417..64bb0dca7e3b 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: event trigger - test inter-event histogram trigger snapshot action
> -# requires: set_event snapshot events/sched/sched_process_fork/hist "onchange(var)":README "snapshot()":README ping:program
> +# requires: set_event snapshot events/sched/sched_process_fork/hist "onchange(var)":README "snapshot()":README ping:program nice:program
>  # flags: instance
>  
>  fail() { #msg
> -- 
> 2.43.0
>
>

-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>