Re: [PATCH v2 3/4] arm64: dts: qcom: talos: Add Talos Lyra EVK board

[Vishnu Saini]

On Mon, Oct 12, 2026 at 02:59:46PM +0300, Dmitry Baryshkov wrote:
> On Mon, Oct 12, 2026 at 11:46:28AM +0530, Ruchira Revdekar wrote:
> > From: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@xxxxxxxxxxxxxxxx>
> > 
> > Add the device tree for the Talos Lyra EVK platform which combines
> > the Talos Lyra EVK SoM and Lyra carrier board.
> > 
> > This device tree adds board-specific peripheral configuration on top
> > of the SoM, including:
> > 
> > - Native DisplayPort output
> > - GPIO expanders on i2c5
> > - SPI-attached TPM (ST33)
> > - USB host and peripheral controllers
> > - Power and reset keys
> > 
> > Co-developed-by: Akash Kumar <akakum@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Akash Kumar <akakum@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Khalid Faisal Ansari <khalid.ansari@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Khalid Faisal Ansari <khalid.ansari@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Vishnu Santhosh <vishnu.santhosh@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Vishnu Santhosh <vishnu.santhosh@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Vishnu Saini <vishsain@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Vishnu Saini <vishsain@xxxxxxxxxxxxxxxx>
> > Tested-by: Nirmesh Kumar Singh <nirmesh.singh@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Ruchira Revdekar <ruchira.revdekar@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile           |   1 +
> >  arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 137 ++++++++++++++++++++++++++++
> >  2 files changed, 138 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 88230c4e00ea..2f25575e6efe 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -456,6 +456,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-valve-deckard.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-mtp.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-qrd.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)	+= talos-lyra-evk.dtb
> >  
> >  talos-evk-el2-dtbs	:= talos-evk.dtb talos-el2.dtbo
> >  
> > diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
> > new file mode 100644
> > index 000000000000..cfb563658fe0
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
> > @@ -0,0 +1,137 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > + */
> > +/dts-v1/;
> > +
> > +#include "talos-lyra-evk-som.dtsi"
> > +
> > +/ {
> > +	model = "Qualcomm Technologies, Inc. QCS615 Talos lyra EVK";
> 
> Is it 'lyra' or 'Lyra'?
> 
> > +	compatible = "qcom,talos-lyra-evk", "qcom,qcs615", "qcom,sm6150";
> > +	chassis-type = "embedded";
> > +
> > +	dp0-connector {
> > +		compatible = "dp-connector";
> > +		label = "DP0";
> > +		type = "full-size";
> > +
> > +		hpd-gpios = <&tlmm 104 GPIO_ACTIVE_HIGH>;
> 
> Why is it being declared here rather than in the DP controller?
> Declaring it here would bypass DP controller state machine.
I keep it similar to talos-evk: https://lore.kernel.org/all/20260331060107.501561-4-tessolveupstream@xxxxxxxxx/
In next revision, i will remove hpd-gpios and use DP controller state machine:

 &mdss_dp0 {
+	pinctrl-0 = <&dp_hot_plug_det>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
 
 &tlmm {
+	dp_hot_plug_det: dp-hot-plug-det-state {
+		pins = "gpio104";
+		function = "dp_hot";
+		bias-disable;
+	};
 
> > +
> > +		port {
> > +			dp0_connector_in: endpoint {
> > +				remote-endpoint = <&mdss_dp0_out>;
> > +			};
> > +		};
> > +	};
> > +
> > +};
> > +
> 
> [..]
> 
> > +
> > +&usb_1 {
> > +	dr_mode = "peripheral";
> 
> Is it going to only support peripheral mode or is OTG going to be added
> later?
> 
> > +
> > +	status = "okay";
> > +};
> > +
> > +&usb_1_hsphy {
> > +	vdd-supply = <&vreg_l5a>;
> > +	vdda-pll-supply = <&vreg_l12a>;
> > +	vdda-phy-dpdm-supply = <&vreg_l13a>;
> > +
> > +	status = "okay";
> > +};
> > +
> > +&usb_2 {
> > +	dr_mode = "host";
> 
> Same question. Is it host-only or will OTG be added later?
> 
> Is there a separate VBUS supply if it's the host mode controller?
> 
> > +
> > +	status = "okay";
> > +};
> > +
> 
> -- 
> With best wishes
> Dmitry