Re: [PATCH v7 3/3] media: i2c: hm1092: Add ACPI enumeration and the 19.2 MHz configuration

[Ray Strode]

Hi,

Regarding the crop-bounds question: the 19.2 MHz mode reports a 1294x734
crop at (0,0), which extends outside the advertised 1280x720 bounds at
(8,8).

Reporting the native array as CROP_BOUNDS accommodates that readout window
while keeping CROP_DEFAULT as the active area:

diff --git a/drivers/media/i2c/hm1092.c b/drivers/media/i2c/hm1092.c
--- a/drivers/media/i2c/hm1092.c
+++ b/drivers/media/i2c/hm1092.c
@@ -836,12 +836,12 @@
 		sel->r = to_hm1092(sd)->mode->crop;
 		return 0;
 	case V4L2_SEL_TGT_CROP_DEFAULT:
-	case V4L2_SEL_TGT_CROP_BOUNDS:
 		sel->r.left = HM1092_ACTIVE_LEFT;
 		sel->r.top = HM1092_ACTIVE_TOP;
 		sel->r.width = HM1092_ACTIVE_WIDTH;
 		sel->r.height = HM1092_ACTIVE_HEIGHT;
 		return 0;
+	case V4L2_SEL_TGT_CROP_BOUNDS:
 	case V4L2_SEL_TGT_NATIVE_SIZE:
 		sel->r.left = 0;
 		sel->r.top = 0;

This changes only the reported bounds; the mode's crop and register
configuration stay the same.