Re: [PATCH v8 3/6] dt-bindings: phy: realtek,usb2phy.yaml: extend for resets and RTL9607C support
From: Rustam Adilov
Date: Thu Oct 15 2026 - 15:47:44 EST
On 2026-10-13 06:05, Krzysztof Kozlowski wrote:
> On 12/10/2026 19:37, Rustam Adilov wrote:
>> Add the "realtek,rtl9607-usb2phy" compatible for USB2 PHY on the RTL9607C
>> SoC series.
>>
>> Add a resets property to properties to describe the usb2phy reset line.
>>
>> In RTL9607C, USB2 PHY reset line is from "IP Enable controller" which is
>> multipurpose and handle activating various SoC peripherals.
>>
>> It is unclear whether RTD SoCs have something similar to that so set
>> the resets to false for these devices.
>>
>> RTL9607C requires the "resets" to be specified so add the corresponding
>> if check for the "realtek,rtl9607-usb2phy" compatible.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Rustam Adilov <adilov@xxxxxxxxxxx>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
>
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> There is never "yaml" in any prefix. Don't come up with own style.
>
>
> Best regards,
> Krzysztof
Oi, i am very sorry about that. I am using the scripts/get_maintainers.pl
command from [1] and it only covers the last commit which was not the one
touching the realtek,usb2phy.yaml so it didn't get any of the device tree
people. I don't exactly know if i can get it to output full maintainer list
in the context of patch series in one swoop without running it across every
single commit and then manually combining all. I think that is what i did in
v7 and prior versions and forgot to do it here.
As for the yaml prefix, will remove it.
[1] https://kernelnewbies.org/FirstKernelPatch#SubmitPatch
Best,
Rustam