Re: [PATCH] can: flexcan: fix runtime PM reference imbalance on probe failure
From: Marc Kleine-Budde
Date: Thu Oct 15 2026 - 16:53:31 EST
On Wed, 16 Sep 2026 01:03:27 +0800, Guangshuo Li <lgs201920130244@xxxxxxxxx> wrote:
> flexcan_probe() increments the runtime PM usage counter with
> pm_runtime_get_noresume() before registering the CAN device.
>
> On successful registration, register_flexcandev() drops this reference
> with pm_runtime_put(). However, if flexcan_setup_stop_mode() subsequently
> fails, the error path unregisters the CAN device and falls through to
> failed_register, where pm_runtime_put_noidle() drops the same reference
> again.
>
> [...]
Reviewed-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
--
Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>