Re: [f2fs-dev] [PATCH v5 00/16] f2fs: support & optimize large folios for writable files

[Jaegeuk Kim]

On 10/15, Jaegeuk Kim via Linux-f2fs-devel wrote:
> On 10/15, Nanzhe Zhao wrote:
> > 
> > Hi Jaeguk:
> > 
> > >Ok, this comes when applying "f2fs: carry subpage offset and count in write IO".
> > >
> > 
> > So we didn't reproduce this bug with the whole series patched on dev-test?
> 
> I hit this after applying the entire patch set. Then, tried to bisect and got an
> issue with that patch in the first round.

Ok, the issue was different when bisecting the patches. After applying the below
change that Chao pointed out, I can continue to bisect. Let's see.

--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1560,6 +1560,7 @@ static int move_data_page(struct inode *inode, block_t bidx, int gc_type,
                        .op_flags = REQ_SYNC,
                        .old_blkaddr = NULL_ADDR,
                        .folio = folio,
+                       .folio_blkcnt = 1,
                        .encrypted_page = NULL,
                        .need_lock = LOCK_REQ,
                        .io_type = FS_GC_DATA_IO,

> 
> > 
> > Thanks,
> > 
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel