Re: [PATCH v3 13/27] KVM: nSVM: Add a placeholder ASID for L2

[Yosry Ahmed]

> > > > diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
> > > > index bfb297b7d71ab..780132725bb79 100644
> > > > --- a/arch/x86/kvm/svm/nested.c
> > > > +++ b/arch/x86/kvm/svm/nested.c
> > > > @@ -701,7 +701,6 @@ static void nested_svm_transition_tlb_flush(struct kvm_vcpu *vcpu)
> > > >          *  - Honor L1's request to flush an ASID on nested VMRUN
> > > >          *  - Sync nested NPT MMU on VMRUN that flushes L2's ASID[*]
> > > >          *  - Don't crush a pending TLB flush in vmcb02 on nested VMRUN
> > > > -        *  - Flush L1's ASID on KVM_REQ_TLB_FLUSH_GUEST
> > >
> > > Um...How does this patch either do this TODO or render it moot?
> >
> > L1 now has a separate ASID from L2, and it's the one we're already
> > flushing with KVM_REQ_TLB_FLUSH_GUEST. It's kinda already moot because
> > we already flush L1's ASID on KVM_REQ_TLB_FLUSH_GUEST.. or maybe it's
> > actually *wrong* because KVM_REQ_TLB_FLUSH_GUEST needs to flush the
> > current ASID, not always L1's ASID.
> >
> > I can drop it separately if that helps.
>
> You could just explain it in the commit message.

Will do.