Re: [PATCH] i2c: stm32f7: close SMBus alert work before removing ARA

[Andi Shyti]

Hi,

In order to take it, I need an ack from Pierr-Yves here.

On Mon, Oct 12, 2026 at 01:16:08AM -0400, Myeonghun Pak wrote:
> Clearing ALERTEN does not join a handler that already observed ALERT.
> It can enqueue work after the ARA client has cancelled work and freed
> its backing state.
> 
> Exclude transfers and join both controller IRQs before detaching the
> alert pointer. Check that pointer before queuing ARA work, and handle
> single-line controllers without disabling the same IRQ twice.
> 
> Resume the controller before masking and clearing ALERT. On resume
> failure, skip MMIO while pointer detachment still closes the producer.
> Restore IRQs and release the bus lock before unregistering ARA so its
> worker can finish an I2C transfer.
> 
> This issue was found by static analysis.

it would be nice to have a real issue here. This theoretical fix
leaves me a bit perplexed.

Andi

> Fixes: c8062d11e20c ("i2c: stm32f7: add SMBus-Alert support")
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>