Re: [PATCH net-next v13 12/12] dpll: sit9531x: model the inter-PLL sync net as a pair of pins

[Ali Rouhi]

On Wed, 14 Oct 2026, sashiko-bot@xxxxxxxxxx wrote:

Reply inline.

> [Severity: Medium] If sit9531x_intsync_src_detect() fails to read
> from the device, the code logs a warning but leaves
> sitdev->intsync_src holding its pre-suspend value. Unlike the output
> mutes right below which set a state_stale flag, is there anything
> triggering a subsequent read if this initial resume read fails?

> [Severity: Medium] The comment in sit9531x_resume() states that "a
> cache that cannot be read is left for the getter's read-through."
> However, this getter directly returns the cached intsync_src value
> without attempting to read from the hardware if the cache is stale.
> Because the resume path does not invalidate the cache on failure,
> could this result in reporting an incorrect, out-of-sync INTSYNC
> state to user space and erroneously accepting or rejecting
> configuration requests?

Agreed on both: nothing triggered the read the comment described, and
the comment named a read-through the INTSYNC getters did not have.

v14 adds intsync_stale, set when the resume read-back of the INTSYNC
source fails.  While it is set, the INTSYNC pin getters and setters
re-read the source from the device before they use the cache and
report a failed read through extack, so what is reported, and what a
set request is checked against, come from the device rather than from
the value held before the suspend.