Re: [PATCH net-next v3 3/6] net: skbuff: replace skb_page_unref() and __skb_frag_unref() with skb_netmem_unref()

From: Mina Almasry

Date: Thu Oct 15 2026 - 23:48:43 EST


On Thu, Oct 15, 2026 at 1:37 PM <netdev-bot+sashiko@xxxxxxxxxx> wrote:
>
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:
>
> - [Low] This commit fixes a real refcount imbalance in
> mlx4_en_complete_rx_desc()…
> - [Low] The commit message describes the mlx4 RX error-path bug as
> "underflowing the page refcount".
> - [Low] At this commit, the new kernel-doc in include/linux/skbuff_ref.h
> names ref-side counterparts that do not match the code.
>

If it's OK with folks I'll just ignore low comments. Even if I
reworded the commit messages, the bot will find some other complaint
about how the commit message is worded I think.

--
Thanks,
Mina