Re: [PATCH v18 09/13] media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible

[Kyrie Wu (吴晗)]

On Mon, 2026-10-12 at 11:33 +0200, Krzysztof Kozlowski wrote:
> On Sat, Oct 10, 2026 at 04:07:13PM +0800, Kyrie Wu wrote:
> > Compared to the previous generation IC, the MT8196 uses SMMU
> > instead of IOMMU and supports features such as dynamic voltage
> > and frequency scaling. Therefore, add "mediatek,mt8196-jpgdec"
> > compatible to the binding document.
> > 
> > Signed-off-by: Kyrie Wu <kyrie.wu@xxxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@xxxxxxxxxxxxx>
> 
> So this has subject "media: dt-bindings:" but a new patch you added
> here
> has completely different subject prefix. Including the re-introduced
> nit, I am sure I already asked you.
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst*L23__;Iw!!CTRNKA9wMg0ARbw!h_fknzbP8753NFS_O2e4gssF2OksmsGX8wmW7BASM61ZHZc4edEsgjEe1PxHWHrio8KJjCzeHmSg8w$
>  
> 
> This is random way of coding, not even checking your git history
> before
> sending to lists.
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,

You are right. I missed the inconsistent subject prefix and repeated
the
redundant "bindings" wording when preparing v18.
In v19, I will change the SMMU patch subject to:
  dt-bindings: soc: mediatek: Add MT8196 JPEG SMMU
I will also recheck the decoder and encoder binding subjects against
submitting-patches.rst for consistency.
Sorry for the oversight, and thank you for pointing it out.

Best regards,
Kyrie