Re: [PATCH] KVM: arm64: Only enable S1PIE and S1POE for a guest with TCR2 and ATS1A

[Fuad Tabba]

Hi Marc,

On Thu, 15 Oct 2026 17:41:16 +0100, Marc Zyngier <maz@xxxxxxxxxx> wrote:
[...]
> > diff --git a/arch/arm64/kvm/config.c b/arch/arm64/kvm/config.c
[...]
> > +static bool feat_s1poe(struct kvm *kvm)
> > +{
> > +        return (kvm_has_feat(kvm, FEAT_S1POE) &&
> > +                kvm_has_feat(kvm, FEAT_TCR2) &&
> > +                kvm_has_feat(kvm, FEAT_ATS1A));
>
> Where's what the relevant bits of the JSON say:
>
> (FEAT_S1POE ==> FEAT_TCR2)
> (FEAT_S1POE ==> FEAT_ATS1A)
> (FEAT_S1POE ==> FEAT_HPDS)
>
> So this is missing an additional check on FEAT_HPDS, which is advertised
> as:
>
> (FEAT_AA64EL1 ==> (FEAT_HPDS <=> (UInt(ID_AA64MMFR1_EL1.HPDS) >= 1)))

Thanks, I'll add the FEAT_HPDS check to feat_s1poe() and respin.

Cheers,
/fuad