Re: [PATCH 3/6] gpiolib: cdev: do not free line IRQs again after the chip is removed

From: Adrian Ambrozewicz

Date: Fri Oct 16 2026 - 03:48:30 EST


On Tue, Oct 13, 2026 at 06:44:33PM +0300, Andy Shevchenko wrote:
> In all cases it also checks for irq to be valid, so embed it here and drop
> those checks below.
>
> if (irq && irq_has_action(irq))

Agreed, and with the name handled the way you suggest on patch 5.

> Slightly better to have it
>
> struct linereq *lr = container_of(nb, struct linereq, device_unregistered_nb);

> for (unsigned int i = 0; i < lr->num_lines; i++)

Both will be in v2.

Adrian