Re: [PATCH] gpiolib: cdev: don't record a line direction the driver refused
From: Adrian Ambrozewicz
Date: Fri Oct 16 2026 - 03:54:17 EST
On Wed, Oct 14, 2026 at 12:56:24PM +0800, Kent Gibson wrote:
> I would change the subject to "don't set GPIOD_FLAG_IS_OUT" as cdev
> doesn't interact directly with the driver - gpiolib does, and the change
> here is unconditional.
Agreed, v2 will be "gpiolib: cdev: don't set GPIOD_FLAG_IS_OUT".
> Not a fan of comments describing why code that should not be here is not
> here.
Fair, I'll drop it.
> Having gpiolib manage GPIOD_FLAG_IS_OUT to keep it consistent with the
> driver state makes sense, so no problem with the code change itself.
Thanks for the review. v2 follows with those two changes.
Adrian