Re: [PATCH v3] drm/appletbdrm: Add suspend and resume support
From: Lukas Wunner
Date: Fri Oct 16 2026 - 04:06:12 EST
On Thu, Oct 15, 2026 at 11:47:36PM +0200, Vasilij Markin via B4 Relay wrote:
> The driver has no USB power management callbacks, so the USB core
> unbinds it before system suspend and binds it again on resume. The DRM
> device is unregistered and registered again on every suspend and resume
> cycle, userspace driving the Touch Bar through it (such as tiny-dfr)
> loses its device, and the Touch Bar stays dark after resume.
>
> Implement suspend and resume with drm_mode_config_helper_suspend() and
> drm_mode_config_helper_resume(), so the device stays registered and the
> last committed state is restored on resume. If the device was reset
> while suspended, repeat the probe-time handshake first.
>
> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Vasilij Markin <vasilij.kernel@xxxxxxxxx>
Applied to drm-misc-next, thanks. Note that we're at the tail end
of the cyce and the drm subsystem has an rc6 cut-off. So this is
v7.5 material.
The Fixes tag could be argued against because this isn't really a fix,
it's more like a missing feature. But I can see how this is useful for
people on older LTS kernels, so I let it slide.
Thanks,
Lukas