Re: [PATCH v3 6/7] spi: cadence-xspi: Add support for panic writes
From: Paul Cercueil
Date: Fri Oct 16 2026 - 04:56:03 EST
Hi Mark,
Le jeudi 15 octobre 2026 à 13:09 +0100, Mark Brown a écrit :
> On Wed, Oct 14, 2026 at 05:43:00PM +0200, Paul Cercueil wrote:
> > From: Tanmay Jagdale <tanmay@xxxxxxxxxxx>
> >
> > Advertise support for panic writes. When a memory op is received with
> > the 'panic' flag set, the driver will then work without relying on
> > interrupts and without sleeping.
>
> We check device properties in cdns_xspi_supports_op() if the kernel is
> built with ACPI support, that ends up using of_find_property() which
> takes the devtree lock which means there's a possibility that we might
> deadlock (eg, if we took a NMI or the CPU fell over at the wrong
> moment). This is probably thin enough it's not worth stopping the
> entire series over, it could be fixed incrementally by storing the
> values during probe.
ACK.
I have an extra set of cleanups in my queue for spi-cadence-xspi so I'll change
it there.
Cheers,
-Paul