Re: [PATCH 3/3] arm64: dts: qcom: monaco-evk: Add suspend-only power collapse state

[Konrad Dybcio]

On 10/14/26 8:15 AM, Maulik Shah wrote:
> 
> 
> On 13-10-2026 14:38, Konrad Dybcio wrote:
>> On 10/5/26 5:29 PM, Maulik Shah wrote:
>>> To achieve SoC low power mode like chip rail power collapse (CxPC),
>>> the Monaco EVK board with four PMICs requires coordinated power-down of
>>> CPUSS and the Safety Island (SAIL) subsystem. This deepest system power
>>> collapse state is reserved for system-wide suspend (s2idle).
>>>
>>> Add the system_suspend domain idle state, mark it with system-state,
>>> and reference it from the system power domain.
>>>
>>> Assisted-by: Codex:GPT-6
>>> Signed-off-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>
>>> ---
>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 17 +++++++++++++++++
>>>  1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> index 539c9c80a808..b2978be6823d 100644
>>> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>> Why is this board-specific?
> The deepest state is only supported on the Monaco EVK board with four PMICs. The monaco-ac-evk.dts is with two PMICs and do not support the power down of SAIL.

Nothing in the commit message explains that.
In any case, this should not be specific to the EVK, but rather we
should probably have a monaco-ac.dtsi holding these differences

Konrad