Re: [PATCH 1/2] dt-bindings: media: i2c: dongwoon,dw9719: Document DW9714VA

[Rob Herring (Arm)]

On Fri, 16 Oct 2026 04:09:29 -0500, wyibo6109@xxxxxxxxx wrote:
> From: Yibo Wang <wyibo6109@xxxxxxxxx>
> 
> The dongwoon,dw9714va compatible names the DW9714V silicon revision
> found on the OnePlus Pad 4 (iceland) camera modules.  DW9714VA is not
> an official part number: it is coined to distinguish this revision,
> which shares its IC INFO id (0xFE) with the other DW9714V revisions.
> 
> In its register-mapped ("advanced") mode it exposes the DW9719
> register interface, with the SAC mode field in MODE shifted by 6 like
> on the DW9800K.  This differs from the advanced-mode layout of the
> currently available DW9714V datasheet (Rev. 0.03G), which puts
> SAC_MODE in [3:0] of SAC_CFG and splits the prescaler and SACT into
> separate registers.
> 
> The datasheet-conformant DW9714V and DW9714A, used in their normal
> (direct DAC) mode, are covered by the dongwoon,dw9714 binding
> instead; see the in-flight series by David Heidelberg documenting
> them:
> 
> https://lore.kernel.org/linux-media/20260729-dw9714v-v1-0-3c479b3cf8c0@xxxxxxx/
> 
> The module-specific SAC tuning is carried by the already-documented
> dongwoon,sac-mode and dongwoon,vcm-prescale properties.
> 
> Cc: David Heidelberg <david@xxxxxxx>
> Signed-off-by: Yibo Wang <wyibo6109@xxxxxxxxx>
> ---
>  .../devicetree/bindings/media/i2c/dongwoon,dw9719.yaml     | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml:21:23: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml: error loading YAML: mapping values are not allowed here
  in "./Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml", line 21, column 23
./Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml:21:23: mapping values are not allowed here
make[2]: *** Deleting file 'Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.example.dts'
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml:21:23: mapping values are not allowed here
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/linux-dt-review/Makefile:1725: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20261016090930.947830-1-wyibo6109@xxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.