Re: [PATCH 35/38] arm: dts: qcom: msm8974: Add newline between subnodes

[Konrad Dybcio]

On 10/16/26 4:15 PM, Waqar Hameed wrote:
> On Mon, Oct 12, 2026 at 17:51 +0200 Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
> 
>> On 10/2/26 12:36 AM, Waqar Hameed wrote:
> 
> [...]
> 
>>>  arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
>>> index 4c2730b34cd1d..1a2f0cc9f8a03 100644
>>> --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
>>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
>>> @@ -960,6 +960,7 @@ replicator_out0: endpoint {
>>>  						remote-endpoint = <&etr_in>;
>>>  					};
>>>  				};
>>> +
>>>  				port@1 {
>>>  					reg = <1>;
>>>  					replicator_out1: endpoint {
>>
>> P.S. ^^ we should also have a \n between the last property and the
>> following subnode
> 
> From `Documentation/devicetree/bindings/dts-coding-style.rst` I read
> 
>   8. Child nodes, where each node is preceded with a blank line
> 
> I guess that also applies to the first subnode after the properties
> then, as you say? If so, let's update dtfmt to add a blank line there as
> well then. Thanks for pointing that out Konrad!
Yeah, thanks!

Konrad