Re: [PATCH 2/3] iio: light: Update DT bindings for GP2AP002

[chr[]]

Am 16.10.26 um 16:45 schrieb Krzysztof Kozlowski:
> On 16/10/2026 16:43, Christoph Rudorff wrote:
> > add missing vled-supply
>
> Please use full sentences.
>
> Why missing? Did you check datasheet?

Yes, I did. I mentioned that in the patch fixing the driver.

> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:

Well, I did ... ok, none of the three commit message subjects of that file 
were well formatted.

> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> Subject - everything is "update". Be specific. See git history for examples.
>
> Please organize the patch documenting the bindings (DT bindings) before
> the patch using that ABI.

Will do!

regards,

chris

> See also:
> https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
>
>
> Best regards,
> Krzysztof