Re: [PATCH v3 5/5] arm64: dts: rockchip: add ISP nodes to rk3588

[Daniel Golle]

On Thu, Aug 27, 2026 at 07:48:34PM +0900, Paul Elder wrote:
> From: Xu Hongfei <xuhf@xxxxxxxxxxxxxx>
>
> Add device tree nodes for the ISP and their iommus on the RK3588.
[...]
> +	isp0: isp@fdcb0000 {
> +		compatible = "rockchip,rk3588-isp";
> +		reg = <0x0 0xfdcb0000 0x0 0x7f00>;
> +		interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH 0>,
> +			     <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH 0>,
> +			     <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH 0>;
> +		interrupt-names = "isp_irq", "mi_irq";

Three interrupts with two names, while the binding in patch 4 has
maxItems: 2 and isp1 below lists two, so dtbs_check rejects isp0. If
134 is the MIPI line it needs a name and an entry in the binding (the
RV1126 has that third line and the driver can use it for the CSI-2
receiver errors); otherwise drop it.

Best regards,
Daniel