Re: [PATCH 1/2] tty: serial: remove hub6 multiport support

[Arnd Bergmann]

On Fri, Oct 16, 2026, at 18:48, Hugo Villeneuve wrote:
> On Fri, 16 Oct 2026 14:59:47 +0200

>> -			scnprintf(buf, size, " I/O:0x%lx, offset 0x%x", port->iobase, port->hub6);
>> +		scnprintf(buf, size, " I/O:0x%lx", port->iobase);
>>  	}
>
> With this simplification, you can now remove the {} braces...

Done

>> diff --git a/drivers/tty/serial/sunsu.c b/drivers/tty/serial/sunsu.c
>> index 4ff3e5c41dab..f43b802add12 100644
>> --- a/drivers/tty/serial/sunsu.c
>> +++ b/drivers/tty/serial/sunsu.c
>> @@ -106,10 +106,6 @@ static unsigned int serial_in(struct uart_sunsu_port *up, int offset)
>>  	offset <<= up->port.regshift;
>>  
>>  	switch (up->port.iotype) {
>> -	case UPIO_HUB6:
>> -		outb(up->port.hub6 - 1 + offset, up->port.iobase);
>> -		return inb(up->port.iobase + 1);
>> -
>>  	case UPIO_MEM:
>>  		return readb(up->port.membase + offset);
>
> Maybe change to a simple if/else?
>
> 	if (up->port.iotype == UPIO_MEM)
> 		return readb(up->port.membase + offset);
> 	else
> 		return inb(up->port.iobase + offset);
>

I think I'd rather not change sunsu.c any more than necessary.

      Arnd