Re: [PATCH 2/2] media: i2c: ov13858: Add device tree support

From: Sergey Lebedev

Date: Fri Oct 16 2026 - 17:08:35 EST


Hi Bryan, George,

On 16/10/2026 21:43, Bryan O'Donoghue wrote:
> b4 prep --edit-deps # add: message-id:
> <20260831130312.26296-1-lsa.uz@xxxxx>

Please make that v4:
https://lore.kernel.org/all/20261016210246.58562-1-lsa.uz@xxxxx/

The suspend test George asked for found one thing in v3. On the Intel
model a system suspend during a stream is refused by the ISYS (intel-ipu6
driver), as isys_suspend() returns -EBUSY while a stream is open. But
DEFINE_RUNTIME_DEV_PM_OPS() gives the driver system sleep handlers, so
pm_runtime_force_suspend() powered the sensor off before that refusal
(ftrace), pm_runtime_force_resume() powered it back without the stream,
and the stream stalled until restarted. v4 has runtime PM ops only, as
camera-sensor.rst asks of sensor drivers: the same refused suspend
reaches no ov13858 callback, and the stream completes all 900 frames.

Otherwise both behave the same here: 20 runtime PM cycles each, and two
s2idle suspends with the camera idle, after which the sensor streams
4224x3136 at 29.95 fps and v4l2-compliance passes 46 of 46. A suspend
that completes during a stream, as it may with CAMSS, cannot happen here.
v4 keeps v3's Tested-by from German and Simon.

Sergey