Re: [PATCH net v5 2/6] can: dev: add close_candev_cancel_restart_sync()

[Cunhao Lu]

Hi,

> [Severity: Low]
> This isn't a bug, but could the commit message say why this is going to
> stable?
>
> On its own, the patch is a no-op refactor of close_candev() plus a new
> helper. It has no Fixes: tag and no "# prerequisite for ..." annotation.

This patch is a prerequisite for the next patch, "can: rockchip_canfd:
cancel bus-off restart before closing the device".

> [Severity: Low]
> In this patch, the only caller of close_candev_cancel_restart_sync() is
> close_candev() in drivers/net/can/dev/dev.c, and that conversion keeps
> the old behaviour. As a result, no driver's ndo_stop gets the early
> cancellation that the commit message describes.
> ...
> Could the commit message mention that user, so the helper doesn't look
> unused when this patch is reviewed alone?

Yes. The following Rockchip patch is the intended user. The current
commit message explains why drivers need the helper, but does not
explicitly name that user. The conversion of close_candev() intentionally
preserves its existing behaviour.

If v6 is needed, I will update the commit message to clarify this.

Regards,
Cunhao Lu