RE: [PATCH v15 06/11] clk: realtek: Add support for gate clock

[Yu-Chun Lin [林祐君]]

Hi Jerome,

> > Introduce clk_regmap_gate_ops supporting enable, disable, and
> > is_enabled for standard regmap gate clocks. To accommodate hardware
> > designs, the enable and disable operations handle a 'write_en' flag,
> > which asserts an adjacent write-enable bit (bit_idx + 1)
> > simultaneously when modifying the gate bit.
> >
> > Add clk_regmap_gate_ro_ops as a read-only variant exposing only
> is_enabled.

[...]

> > +#define RTK_CLK_REGMAP_GATE_NO_PARENT(_name, _flags, _ofs,
> _bit_idx, _write_en)        \
> > +     __RTK_CLK_REGMAP_GATE_NO_PARENT(_name,
> &rtk_clk_regmap_gate_ops, _flags, _ofs, \
> > +                                 _bit_idx, _write_en)
> > +
> > +#define RTK_CLK_REGMAP_GATE_NO_PARENT_RO(_name, _flags, _ofs,
> _bit_idx, _write_en)  \
> > +     __RTK_CLK_REGMAP_GATE_NO_PARENT(_name,
> &rtk_clk_regmap_gate_ro_ops, _flags, \
> > +                                 _ofs, _bit_idx, _write_en)
> 
> Is this _NO_PARENT still used ? if not drop it

Ack. Will drop.

Best Regards,
Yu-Chun
> 
> --
> Jerome