RE: [PATCH v15 09/11] clk: realtek: Add RTD1625-CRT clock controller driver

[Yu-Chun Lin [林祐君]]

Hi Jerome,

> > +static const char * const clk_gpu_parents[] = {"pll_gpu", "clk_sys"};
> > +static RTK_CLK_REGMAP_MUX(clk_gpu, clk_gpu_parents,
> CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT,
> > +                       0x28, 12, 0x1); static const char * const
> > +clk_ve_parents[] = {"pll_vodma", "clk_sysh", "pll_ve1", "pll_ve2"};
> > +static RTK_CLK_REGMAP_MUX(clk_ve1, clk_ve_parents,
> CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT,
> > +                       0x4c, 0, 0x3); static
> > +RTK_CLK_REGMAP_MUX(clk_ve2, clk_ve_parents, CLK_SET_RATE_PARENT
> | CLK_SET_RATE_NO_REPARENT,
> > +                       0x4c, 3, 0x3); static
> > +RTK_CLK_REGMAP_MUX(clk_ve4, clk_ve_parents, CLK_SET_RATE_PARENT
> | CLK_SET_RATE_NO_REPARENT,
> > +                       0x4c, 6, 0x3); static
> > +RTK_CLK_REGMAP_GATE(clk_en_misc, "clk_sys", CLK_IS_CRITICAL, 0x50, 0,
> > +1);
> 
> You are using the using the old global names but there does not seem to be a
> good reason for this. Your driver is entirely static so the hw are known at
> compile time and you can use them. Use .parent_hws or parent_data when
> appropriate. Not parent_names please.

Thanks for your advice.

We will remove the old 'RTK_CLK_REGMAP_GATE()' and 'RTK_CLK_REGMAP_MUX()'
macros and introduce macros, which use 'CLK_HW_INIT_HW()' to
directly reference '.parent_hws' instead of relying on string names.

Best Regards,
Yu-Chun
> 
> --
> Jerome