Re: [PATCH v3] xsk: fix memory corruptions in net/core/xdp.c

[Björn Töpel]

Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> writes:

>> Or am I missing another check?
>
> I missed your trick with xdp.frags on prog side. Get this fixed then!
> :D I

...so many bugs... ;)

> had a thought like 'who cares if we overwrite struct not used in linear
> traffic' but as Clement said somewhere destructor_arg overwrite would make
> a mess.
>
> Side note is ice currently still only allows 3k buffers for linear XDP
> progs but it currently works with page_pool not with magic page split
> mechanism, so the limit should be lifted.
>
> I might take this as an AR but anyone reading this in future feel free to
> pick it up.
>
> Bjorn, let us see if Clement responses in some nearby future, otherwise
> please go forward and submit a standalone fix out of your series.

SG!

Björn