Re: [PATCH v7 4/7] RAS/AMD/ATL: Match AMD CPUs only

[Yazen Ghannam]

On Fri, Oct 09, 2026 at 05:01:08PM +0800, Lin Wang wrote:
> ATL matches Hygon through X86_FEATURE_SMCA and X86_FEATURE_ZEN, but
> relies on the AMD northbridge cache for its node count and F4 devices.
> The cache uses fixed PCI slots that do not represent the Hygon topology.
> 
> The cache is therefore discarded before ATL can register its decoder,
> so excluding Hygon from these feature matches does not disable a
> working address translation path.
> 
> Qualify both feature matches with the AMD vendor. Hygon address
> translation will use the Hygon node interfaces in a separate series.
> 
> Signed-off-by: Lin Wang <wanglin@xxxxxxxxxxxxxx>
> ---
>  drivers/ras/amd/atl/core.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ras/amd/atl/core.c b/drivers/ras/amd/atl/core.c
> index d77dacdd4f56..fe84fc52c657 100644
> --- a/drivers/ras/amd/atl/core.c
> +++ b/drivers/ras/amd/atl/core.c
> @@ -176,18 +176,17 @@ static void check_for_legacy_df_access(void)
>  }
>  
>  /*
> - * This library provides functionality for AMD-based systems with a Data Fabric.
> + * This library provides functionality for AMD systems with a Data Fabric.
>   * The set of systems with a Data Fabric is equivalent to the set of Zen-based systems
>   * and the set of systems with the Scalable MCA feature at this time. However, these
>   * are technically independent things.
>   *
>   * It's possible to match on the PCI IDs of the Data Fabric devices, but this will be
> - * an ever expanding list. Instead, match on the SMCA and Zen features to cover all
> - * relevant systems.
> + * an ever expanding list. Instead, match AMD CPUs with the SMCA and Zen features.
>   */
>  static const struct x86_cpu_id amd_atl_cpuids[] = {
> -	X86_MATCH_FEATURE(X86_FEATURE_SMCA, NULL),
> -	X86_MATCH_FEATURE(X86_FEATURE_ZEN, NULL),
> +	X86_MATCH_VENDOR_FEATURE(AMD, X86_FEATURE_SMCA, NULL),
> +	X86_MATCH_VENDOR_FEATURE(AMD, X86_FEATURE_ZEN, NULL),
>  	{ }
>  };
>  
> -- 

Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>

Thanks,
Yazen