Re: [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device

[Frieder Hannenheim]

On 17.10.26 18:46, Krzysztof Kozlowski wrote:
> On Thu, Oct 15, 2026 at 02:32:37PM +0200, Frieder Hannenheim wrote:
> > Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
> >
> > [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
> >
> > Signed-off-by: Frieder Hannenheim <git@xxxxxxxxxxxxxxx>
> > Co-developed-by: Robert Oscilowski <drgitx@xxxxxxxxx>
> > Signed-off-by: Robert Oscilowski <drgitx@xxxxxxxxx>
>
> Your SoB is the last. Please follow closely submitting patches document.
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
> Best regards,
> Krzysztof
Hi Krzysztof,

thanks for pointing this out. I will put my SoB last. I have run 
checkpatch (see the output below) and it has shown me no warnings that I 
deem actionable. (MAINTAINERS does not seem to contain other dt 
maintainers and wrapping the link would break it).

Kind regards,
Frieder

$ ./scripts/checkpatch.pl -g HEAD-3 --strict
> -------------------------------------------------------------------
> Commit 3b78f6c36076 ("dt-bindings: arm: qcom: Document OnePlus 8T")
> -------------------------------------------------------------------
> total: 0 errors, 0 warnings, 0 checks, 7 lines checked
>
> Commit 3b78f6c36076 ("dt-bindings: arm: qcom: Document OnePlus 8T") has no obvious style problems and is ready for submission.
> ------------------------------------------------------------------------
> Commit 485091777ce8 ("arm64: dts: qcom: Add sm8250-oneplus-common.dtsi")
> ------------------------------------------------------------------------
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #18: 
> new file mode 100644
>
> total: 0 errors, 1 warnings, 0 checks, 607 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> Commit 485091777ce8 ("arm64: dts: qcom: Add sm8250-oneplus-common.dtsi") has style problems, please review.
> -------------------------------------------------------------------
> Commit 72db2e5d2c06 ("arm64: dts: qcom: oneplus-kebab: new device")
> -------------------------------------------------------------------
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #8: 
> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
>
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #32: 
> new file mode 100644
>
> total: 0 errors, 2 warnings, 0 checks, 137 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> Commit 72db2e5d2c06 ("arm64: dts: qcom: oneplus-kebab: new device") has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.