Re: [PATCH v5 03/15] iio: adc: ad4134: Apply reset recovery wait time
From: Jonathan Cameron
Date: Sat Oct 17 2026 - 15:13:45 EST
On Sat, 17 Oct 2026 07:55:13 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> On Fri, 16 Oct 2026 22:57:08 -0300
> Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote:
>
> > Add a reset recovery wait time to avoid any SPI transfer from running too
> > soon during device probe.
> >
> > Fixes: e0bc6d7e2584 ("iio: adc: Initial support for AD4134")
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> > ---
> > New patch in v5.
> >
> > drivers/iio/adc/ad4134.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/adc/ad4134.c b/drivers/iio/adc/ad4134.c
> > index 40b27b01f126..d555874b4959 100644
> > --- a/drivers/iio/adc/ad4134.c
> > +++ b/drivers/iio/adc/ad4134.c
> > @@ -442,6 +442,7 @@ static int ad4134_probe(struct spi_device *spi)
> > return dev_err_probe(dev, PTR_ERR(rst),
> > "failed to get and deassert reset\n");
> >
> > + fsleep(AD4134_RESET_TIME_US);
Sashiko calls out that this is currently 10 seconds, which seems unlikely!
> > crc8_populate_msb(ad4134_spi_crc_table, AD4134_SPI_CRC_POLYNOM);
> >
> > st->regmap = devm_regmap_init(dev, NULL, st, &ad4134_regmap_config);
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
>