Re: [PATCH v3 0/2] iio: proximity: Add Vishay VCNL36829 driver

[Jonathan Cameron]

On Fri, 16 Oct 2026 09:22:16 +0800
Liu Yufei <lyf98405@xxxxxxxxx> wrote:

> From: Liu Yufei <lyf98405@xxxxxxxxx>
> 
> This series adds support for the Vishay VCNL36829, an I2C proximity
> sensor with an integrated VCSEL emitter.
> 
> Patch 1 adds the devicetree binding.
> Patch 2 adds the IIO driver, which exposes the proximity reading and
> a configurable integration time.
> 
> Tested on Orange Pi Zero 2W.

Hi Liu Yufei,

Small process thing first.  Start a fresh thread for each version.
This is to avoid the treads becoming complex to follow and has the side
effect that they actually turn up as 'recent' in reviewer's inboxes.

I'd have looked at this a lot later today (or perhaps not at all)
if I didn't happen to notice it in patch work after changing status
on another patch.

Jonathan

> 
> Changes in v3:
> - driver: Collect Reviewed-by from Joshua Crofts and Andy Shevchenko.
> - driver: Use dev_info() instead of dev_warn() for an unknown device
>   ID (Joshua Crofts).
> - driver: Wrap the write_raw() arguments on a logical boundary
>   (Andy Shevchenko).
> 
> Changes in v2:
> - dt-bindings: Collect Reviewed-by from Krzysztof.
> - driver: Address review comments from Andy:
>   - Use a Datasheet: tag in the commit message.
>   - Drop mod_devicetable.h, sort the includes and include what is used.
>   - Drop the i2c_client pointer from the private data and use
>     regmap_get_device() instead.
>   - Drop the unused i2c_set_clientdata().
>   - Enable a maple regmap cache, mark PS_DATA and DEV_ID volatile.
>   - Rework the integration time validation in write_raw().
>   - Use reverse xmas tree order for local variables.
>   - Document the power-up delay and use 3 * USEC_PER_MSEC.
>   - Warn and continue on an unknown device ID instead of failing.
>   - Join lines that fit within 100 columns.
>   - Simplify the Assisted-by tag.
> - driver: Drop the i2c_check_functionality() call, as
>   devm_regmap_init_i2c() already checks the adapter capabilities.
> 
> Link to v2: https://lore.kernel.org/linux-iio/20261006100943.78971-1-lyf98405@xxxxxxxxx/
> Link to v1: https://lore.kernel.org/linux-iio/20261003050453.413700-1-lyf98405@xxxxxxxxx/
> 
> Liu Yufei (2):
>   dt-bindings: iio: proximity: Add Vishay VCNL36829
>   iio: proximity: Add driver for Vishay VCNL36829
> 
>  .../iio/proximity/vishay,vcnl36829.yaml       |  55 ++++
>  MAINTAINERS                                   |   6 +
>  drivers/iio/proximity/Kconfig                 |  11 +
>  drivers/iio/proximity/Makefile                |   1 +
>  drivers/iio/proximity/vcnl36829.c             | 298 ++++++++++++++++++
>  5 files changed, 371 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/vishay,vcnl36829.yaml
>  create mode 100644 drivers/iio/proximity/vcnl36829.c
> 
> base-commit: 52c36105f76e96b638152a42e735f2e7767ed946